Monday, 4 February 2013< ^ >
arjan has set the subject to: Zotonic - the Erlang Content Management Framework
Room Configuration

[08:00:44] Protagores joins the room
[08:57:28] Andreas Stenius joins the room
[09:14:14] maas.maarten.zeeman joins the room
[09:16:22] <Andreas Stenius> Hi maas.maarten.zeeman :) thinking about the stats stuff... are you busy?
[09:16:41] <Andreas Stenius> the issue comments can get lengthy... :p
[09:17:42] <maas.maarten.zeeman> I'm busy, but can discuss for a couple of minutes.
[09:17:45] <maas.maarten.zeeman> -)
[09:17:49] <Andreas Stenius> :)
[09:18:38] <Andreas Stenius> to get rid of the event manager, maybe just have a config pointing to a module bridge that will translate the update calls into the target specific api (statman, folsom, graphite, ...)
[09:18:40] <maas.maarten.zeeman> When I look at folsom implementation. It was based on gen_event
[09:18:44] <Andreas Stenius> ah
[09:18:56] <Andreas Stenius> I'm happy with going for statman, btw ;)
[09:19:11] <maas.maarten.zeeman> It was removed in favour of an ets based collection scheme
[09:19:30] <Andreas Stenius> also makes a nice move if we are going to use elli later on ;)
[09:19:36] <maas.maarten.zeeman> with a parallel write setup.
[09:19:51] <maas.maarten.zeeman> haha. yes. going to look into that.
[09:20:03] <maas.maarten.zeeman> hooking it into webmachine will be interesting
[09:20:51] <Andreas Stenius> we could put a module name in the context for who z_stats should forward updates to
[09:21:57] <maas.maarten.zeeman> Right, yes, but some of the stats collection is inside webzmachine . This part doesn't have the collection
[09:21:59] <Andreas Stenius> something like: `z_stats:update(#data..., Context) -> MOD:update(#data, Context).` where MOD comes from the Context...
[09:22:04] <Andreas Stenius> ah
[09:22:07] <Andreas Stenius> right.
[09:22:40] <maas.maarten.zeeman> That is just in one or two locations though
[09:22:53] <Andreas Stenius> but if the info comes from a app environment variable, webmachine could pick it up too, and store it somewhere...
[09:23:18] <maas.maarten.zeeman> Indeed, that is much better :-)
[09:24:11] <Andreas Stenius> That way we get minimal overhead (just a extra level of call indirection) and still flexibility to swap event sink with a change of config value.
[09:24:32] <maas.maarten.zeeman> Sounds like a plan :-)
[09:25:11] <maas.maarten.zeeman> Thanks, thats much better than fiddeling with magically available modules
[09:25:15] <Andreas Stenius> :) I don't think we need to have it configurable at runtime, a restart should be fine for swapping stats backends... ;)
[09:25:23] <Andreas Stenius> indeed :)
[09:27:01] <Andreas Stenius> I'll post the plan to the issue so it's there for the record too... (a little more visible, at least, than these logs :p )
[09:27:55] <maas.maarten.zeeman> Indeed thanks. Founds some issues in the webzmachine - zotonic coupling too. Need to investigate that.
[09:29:02] <maas.maarten.zeeman> Having to do with the handled response from a dispatcher. (for redirects)
[09:30:01] <maas.maarten.zeeman> Like this one expecting a handled atom https://github.com/zotonic/webzmachine/blob/zynamo/src/webmachine_mochiweb.erl#L154
[09:31:24] <maas.maarten.zeeman> And this one returning tuples.. https://github.com/zotonic/zotonic/blob/master/src/support/z_sites_dispatcher.erl#L124
[09:33:10] <maas.maarten.zeeman> Have to check that as I'm not sure what happens there.
[09:33:36] <Andreas Stenius> looks like a case missmatch on first glance over...
[09:35:01] <maas.maarten.zeeman> Have to check with marc I guess. This is way code way down which you normally don't look at.
[09:35:40] <Andreas Stenius> indeed. I bet there are plenty of things to improve down in those trenches though...
[09:36:37] <maas.maarten.zeeman> yup. mochiweb is mostly based on list based strings also.
[09:36:58] <maas.maarten.zeeman> but it works. :-)
[09:37:04] <Andreas Stenius> and has stuff in the process registry, I noticed...
[09:37:08] <Andreas Stenius> it does :)
[09:39:07] <maas.maarten.zeeman> I have to get get going with other stuff. Thanks andreas for all the feedback. :-)
[09:42:26] <Andreas Stenius> Me too, so I'll leave you to it :)
[09:42:37] <maas.maarten.zeeman> Need that stat collection for planning resources for a site.
[09:44:04] <Andreas Stenius> I think that the stats backend module need to be passed along with the stats update as there is no where to store the information, and we shouldn't rely on the zotonic context.
[09:44:35] <Andreas Stenius> z_stats:update(#update{}, Mod).
[09:44:58] <Andreas Stenius> No need to reply now, do it later, or tomorrow... :)
[09:45:02] <maas.maarten.zeeman> a sort of mini context
[09:45:06] <maas.maarten.zeeman> :-)
[09:45:07] <Andreas Stenius> yeah
[09:45:12] <Andreas Stenius> stats context :)
[09:48:10] <maas.maarten.zeeman> That is a nice idea indeed.
[09:48:40] <Andreas Stenius> just posted a "executive summary" ;)
[09:50:04] <Andreas Stenius> here: https://github.com/zotonic/zotonic/issues/508 <https://github.com/zotonic/zotonic/issues/508>
[09:56:48] <maas.maarten.zeeman> Thanks, that says it all.
[12:14:18] Andreas Stenius leaves the room
[12:18:27] Andreas Stenius joins the room
[15:39:01] maas.maarten.zeeman leaves the room
[15:42:30] Maas joins the room
[16:18:52] Protagores is now known as protagores
[16:37:14] protagores leaves the room
[16:38:09] protagores joins the room
[17:31:52] Maas leaves the room
[18:01:33] vladimir.chujkov joins the room
[18:35:36] vladimir.chujkov leaves the room
[19:37:52] maas.maarten.zeeman joins the room
[19:40:30] protagores leaves the room
[20:27:53] Andreas Stenius leaves the room
[20:27:58] Andreas Stenius joins the room
[21:08:06] Andreas Stenius leaves the room
[21:27:05] Jeff Bell joins the room
Powered by ejabberd Powered by Erlang Valid XHTML 1.0 Transitional Valid CSS!